On Fri, 15 Nov 2019 10:01:51 GMT, Arun Joseph <ajos...@openjdk.org> wrote:
> The pull request has been updated with additional changes. > > ---------------- > > Added commits: > - ca460353: Remove ignore imports and update copyright > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/42/files > - new: https://git.openjdk.java.net/jfx/pull/42/files/f2f121d9..ca460353 > > Webrevs: > - full: https://webrevs.openjdk.java.net/jfx/42/webrev.01 > - incr: https://webrevs.openjdk.java.net/jfx/42/webrev.00-01 > > Issue: https://bugs.openjdk.java.net/browse/JDK-8234239 > Stats: 6 lines in 3 files changed: 0 ins; 3 del; 3 mod > Patch: https://git.openjdk.java.net/jfx/pull/42.diff > Fetch: git fetch https://git.openjdk.java.net/jfx pull/42/head:pull/42 I added some questions and one requested change below. modules/javafx.web/src/test/java/test/javafx/scene/web/LeakTest.java line 82: > 81: } > 82: > 83: @Test public void testGarbageCollectability() throws > InterruptedException { RT-26710, aka [JDK-8088139](https://bugs.openjdk.java.net/browse/JDK-8088139), is still listed as open. Since these tests no longer hang, can you close [JDK-8088139](https://bugs.openjdk.java.net/browse/JDK-8088139) as "Cannot reproduce"? modules/javafx.web/src/test/java/test/javafx/scene/web/LeakTest.java line 58: > 57: > 58: @Test public void testOleg() throws InterruptedException{ > 59: final String URL = new > File("src/test/resources/test/html/guimark2-vector.html").toURI().toASCIIString(); This test takes 80 seconds (`16 * 5 * 1sec`) to run, which is too long for a simple unit test, when the entire rest of the test suite takes about 5 minutes. I recommend decreasing the duration of the key frame to 200 msec, which would allow the test to run in 16 seconds. modules/javafx.web/src/test/java/test/javafx/scene/web/CallbackTest.java line 90: > 89: > 90: @Test public void testDefaultPopup() { > 91: clear(); This test, along with `testCustomPopup` is listed as unstable. Have you run it multiple times on different systems? ---------------- Changes requested by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/42
