On Thu, 19 Dec 2019 15:12:01 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> The pull request has been updated with 1 additional commit. > > I haven't looked at the fix itself, but there are two things that _must_ be > fixed before this PR can be considered: > 1. You need to remove the additional 3rd-party test library dependency. > 2. You need to revert the change that makes a test method public API. As mentioned, I could copy the class of the library into the JavaFX-Project. Alternatively, I could remove the unit-test entirely. But to be honest, the current state related to memory-leaks in the JavaFX project is a bit questionable. JavaFX is filled with leaks and code which could have leaks. I would like to add many more tests like this into the JavaFX-CodeBase. But without the class/library I can only write unreadable code filled with sleeps, Weakreferences etc., which would be sad because now I know how to do it better. ------------- PR: https://git.openjdk.java.net/jfx/pull/71
