On Tue, 17 Dec 2019 13:47:50 GMT, Frederic Thevenet
<github.com+7450507+ftheve...@openjdk.org> wrote:
> This PR aims to address the following issue: JDK-8088198 Exception thrown
> from snapshot if dimensions are larger than max texture size
>
> In order to do that, it simply captures snapshots in multiple tiles of
> maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the
> tiles into a a single image.
> Other than that, the logic used to do the actual snapshot is unchanged.
>
> Tests using the existing SnapshotCommon class have been added in a new file
> named Snapshot3Test under SystemTest/test/javafx/scene.
> These tests pass with the proposed fix, and fail without, throwing "
> java.lang.IllegalArgumentException: Unrecognized image loader: null"
modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1286:
> 1285: Node root, BaseTransform transform,
> boolean depthBuffer,
> 1286: Paint fill, Camera camera,
> WritableImage wimg) {
> 1287:
Generally we avoid only formatting changes. It will be acceptable to change
formatting of the code which is getting modified for the fix. Please do not
include only formatting changes, which are not required for the fix.
-------------
PR: https://git.openjdk.java.net/jfx/pull/68
