On 12/27/19 4:40 PM, John-Val Rose wrote:
Ty,

If it’s so easy to fix then why don’t you just fix it?


I don't exactly have the ability to directly push changes to the repo...



John-Val

On 28 Dec 2019, at 09:14, Ty Young <[email protected]> wrote:


On 12/27/19 4:19 AM, Johan Vos wrote:
Hi David,

What tutorial are you talking about? If you refer to https://openjfx.io,
that is a community-initiative, developed at
https://github.com/openjfx/openjfx-docs .
So if you have issues and PR's, that is the place to submit and discuss
with the other contributors to that site.

Only the Netbeans section has a warning telling you to delete src.zip. Neither 
Intellij nor Eclipse do.


A user shouldn't have to do that anyway though! This could be easily fixed. 
Literally all you need to do is in this section:


// Zip module sources for standalone SDK
     //
     // NOTE: the input is taken from the modular-sdk/modules_src dir
     // so that we don't have to duplicate the logic and create another
     // temporary directory. This is somewhat inelegant, since the bundled sdk
     // and the standalone sdk should be independent of one another, but seems
     // better than the alternatives.
     def zipSourceFilesTask = 
project.task("zipSourceFilesStandalone$t.capital", type: Zip, dependsOn: 
buildModulesTask) {
         destinationDir = file("${standaloneLibDir}")
         archiveName = standaloneSrcZipName
         includeEmptyDirs = false
         from modulesSrcDir
         include "**/*.java"
     }


change:

Reply via email to