On Mon, 30 Dec 2019 11:05:55 GMT, Johan Vos <j...@openjdk.org> wrote:
> This allows to build the JavaFX jars and native libraries for Android devices
I did a test build on Linux since there were changes to the shared Monocle
classes. I didn't really look at the `android.gradle` changes or the new
`android/nativeBridge.c` file, but I don't have any concerns. I did leave a
couple minor formatting comments and one copyright year issue.
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/AndroidInputDeviceRegistry.java
line 62:
> 61: }
> 62: Platform.runLater( () -> instance.gotTouchEvent(touchState));
> 63: }
Minor: normally we wouldn't put a space between the initial `(` and the `()`
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleApplication.java
line 229:
> 228: ns.getWidth(), ns.getHeight(),
> 229: 1.f,1.f, ns.getScale(),
> ns.getScale());
> 230: // Move the cursor to the middle of the screen
Minor: add a space after the first `,`
modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/MonocleWindowManager.java
line 175:
> 174: Platform.runLater(new Runnable () {
> 175: @Override
> 176: public void run() {
Other than removing the one blank line above, this file is unchanged. Perhaps
it could be reverted?
modules/javafx.graphics/src/main/native-glass/monocle/android/nativeBridge.h
line 2:
> 1: /*
> 2: * Copyright (c) 2019, Oracle and/or its affiliates. All rights reserved.
> 3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
That should be `2012, 2019, Oracle...` so as not to lose the initial year (well
actually `2012, 2020, Oracle...` as of Jan 1, but that will get updated the
next time I run my copyright script, which I plan to do right before RDP2, so
either 2019 or 2020 for the last-modified year is fine).
-------------
PR: https://git.openjdk.java.net/jfx/pull/75
