On Wed, 18 Dec 2019 01:04:42 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
> https://bugs.openjdk.java.net/browse/JDK-8232589 > > - Removed CoreAudio Utility classes. > - Spectrum which was depended on CoreAudio Utility classes for doing > computations will now run GStreamer spectrum element to do spectrum. Element > will be run without pipeline and will be used as utility library to do > spectrum calculation. I added extra APIs to bypass proper element > initialization. > - Equalizer and audio unit (volume and balance) where modified, so we can run > then directly without CoreAudio pipeline. The changes look ok to me, and the build + tests are nominal. Since there are new calculations being used now, I am slightly concerned about performance regression, but this is very hard to measure, so I suggest we build an EA release once the PR is merged. ------------- Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/69
