On Tue, 4 Feb 2020 16:41:20 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> Update the version of Lucene used by Ensemble to the latest release of 
>> Lucene 7 which is version 7.7.2.
>> 
>> Per the instructions in 
>> [`UPDATING-lucene.txt`](https://github.com/openjdk/jfx/blob/master/apps/samples/Ensemble8/UPDATING-lucene.txt),
>>  I made the following changes:
>> 
>> 1. Bumped the version numbers from 7.7.1 to 7.7.2 in all needed places
>> 
>> I did not regenerated the index files, since only the `bugfix` number (the 
>> third digit) changed. It is the same `major.minor` release as before.
>> 
>> To test this: apply the patch, run `gradle apps`, launch Ensemble8, and 
>> search for a sample or JavaFX component in the upper-right search box.
> 
> @aghaisas can you review this?

I pushed a new commit that reverts the changes to the stored binary index 
files. There is no need to regenerate them when upgrade to a new version where 
only the `bugfix` number (the third digit) changes. This minimizes the churn 
and avoids modifying the binary index files needlessly. I added a note to this 
effect in the updated 
[`UPDATING-lucene.txt`](https://github.com/openjdk/jfx/blob/6facff5d7b7a9160939a5b4231a8355a617377a6/apps/samples/Ensemble8/UPDATING-lucene.txt)
 file.

-------------

PR: https://git.openjdk.java.net/jfx/pull/105

Reply via email to