On Fri, 14 Feb 2020 09:09:13 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
> Bug : https://bugs.openjdk.java.net/browse/JDK-8235480 > > Fix : Added the missed out RTL checks to the key mappings in > TableViewBehaviorBase class. > > Testing : Modified unit tests in TableViewKeyInputTest to take orientation as > a parameter. The Left/Right key press tests have been modified to address LTR > and RTL orientations. > > Note : If this test modification is acceptable, I would like to address other > similar tests separately. (I will create a test JBS issue and address later) modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java line 152: > 151: > 152: new KeyMapping(LEFT, (rtl? e -> selectRightCell() : e -> > selectLeftCell())), > 153: new KeyMapping(KP_LEFT, (rtl? e -> selectRightCell() : e > -> selectLeftCell())), ... so a keyMapping based on the initial condition will fail after a change of orientation, or what am I missing? (aside: I really hate this review ui, can't seem to make it take several comments ... argghh) ------------- PR: https://git.openjdk.java.net/jfx/pull/114
