On Tue, 18 Feb 2020 09:02:36 GMT, dannygonzalez <github.com+6702882+dannygonza...@openjdk.org> wrote:
>> @dannygonzalez the reason for the `jcheck` failure is that you have commits >> with two different email addresses in your branch. At this point, it's >> probably best to squash the commits into a single commit with `git rebase -i >> master` (presuming that your local `master` is up to date), and then do a >> force-push. > > @kevinrushforth just a note to say there are other ExpressionHelper classes > (i.e. MapExpressionHelper, SetExpressionHelper and ListExpressionHelper) that > also use arrays and suffer from the linear search issue when removing > listeners. > > These however didn't appear in the critical path of the JavaFXThread and > didn't come up in my profiling of TableView. > > If this pull request is accepted, my opinion is that they should probably all > move to using the same pattern as here, which is to use Maps instead of > Arrays for their listener lists so that all these classes are uniform. > > Thanks Sorry for the interruption, send a PR that corrects the same problem. ------------- PR: https://git.openjdk.java.net/jfx/pull/108
