On Tue, 25 Feb 2020 13:54:25 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Sorry, mixed up the link with the test unit WIP! :( >> >> This is the correct link with the explanatory text related to this suggested >> fix. Posted [1] which explains the problem and the suggested solution for >> discussion. >> [1] 'Ad suggested fix for "JDK-8234959 FXMLLoader does not populate >> ENGINE_SCOPE Bindings with FILENAME and ARGV"': >> <https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-February/025102.html> > > @aghaisas can you also review this? Overall this looks good to me. As I mentioned in PR #123 you should fold that the unit test into this PR. ------------- PR: https://git.openjdk.java.net/jfx/pull/122
