On Mon, 2 Mar 2020 10:07:24 GMT, Florian Kirmaier <fkirma...@openjdk.org> wrote:
>> Rather than removing the test, I was suggesting that you create a test for >> memory leaks using the same ad hoc approach that our other memory leak tests >> use. This could later be modified to use the new GC test utility as part of >> creating that utility. The pattern used in, for example, >> [TabPaneHeaderLeakTest.java](https://github.com/openjdk/jfx/blob/master/tests/system/src/test/java/test/javafx/scene/control/TabPaneHeaderLeakTest.java), >> works well enough, even though it repeats a fair amount of boilerplate code. > > I've now readded the unit-test. It based on the "InitialNodesMemoryLeakTest". > > Command to execute: `./gradlew -PFULL_TEST=true -PUSE_ROBOT=true > :systemTests:test --tests test.javafx.scene.control.ProgressIndicatorLeakTest` > > It's now part of the systemtests, because the memory-semantics for the tests > in controls is changed due to the TestToolkit. > It's now part of the systemtests, because the memory-semantics for the tests > in controls is changed due to the TestToolkit. just curious: does that imply that you think the tests in controls ... rather useless? ------------- PR: https://git.openjdk.java.net/jfx/pull/71
