On Thu, 5 Mar 2020 17:17:57 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> The JDK 14 javadoc will emit a warning for an `@pram` tag of a generic >> parameter if not surrounded by `<` and `>`. This will in turn fail the >> build, since we treat warnings as errors. There are 5 classes in JavaFX with >> this error. The fix is to replace `@param T` with `@param <T>` in those 5 >> places. >> >> >> I have tested this fix using javadoc from both JDK 13 and JDK 14. > > Using a rough regex search of `@param [A-Z]\s` I also found: > > `com.sun.glass.ui.Window#requestInput`: `@param M` > `com.sun.javafx.tk.TKStage#requestInput`: `@param M` > > Though those are internal. Thanks for the review. Yeah, I only looked at the public API classes. Can I get a "R"eviewer to look at this? Maybe @arapte or @aghaisas ? ------------- PR: https://git.openjdk.java.net/jfx/pull/133
