> Hi everyone, > > ticket: https://bugs.openjdk.java.net/browse/JDK-8236259 > > The fix itself is quite straight forward. > It basically just removed the listener which causes the leak. > > The unit-test for the fix is a bit more complicated. > > I added a library JMemoryBuddy https://github.com/Sandec/JMemoryBuddy > (written by myself), which simplifies testing for > memory leaks. I think there are many places in the JavaFX-codebase that could > highly benefit from this library. > It could also simplify many of the already existing unit tests. > It makes testing for memory-leaks readably and reliable. > It would also be possible to just copy the code of the library into the > JavaFX-codebase. > It only contains a single class. > > I also had to make a method public, to write the test. I'm open to ideas, how > I could solve it differently.
Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision: JDK-8200224 removed create garbage ------------- Changes: - all: https://git.openjdk.java.net/jfx/pull/71/files - new: https://git.openjdk.java.net/jfx/pull/71/files/ba595494..bfb6d1c7 Webrevs: - full: https://webrevs.openjdk.java.net/jfx/71/webrev.06 - incr: https://webrevs.openjdk.java.net/jfx/71/webrev.05-06 Stats: 10 lines in 1 file changed: 0 ins; 10 del; 0 mod Patch: https://git.openjdk.java.net/jfx/pull/71.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/71/head:pull/71 PR: https://git.openjdk.java.net/jfx/pull/71
