On Fri, 13 Mar 2020 17:23:52 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewHorizontalArrowsTest.java
>> line 122:
>>
>>> 121: }
>>> 122:
>>> 123: /**
>>
>> changing the parameter of the test is at least unusual, should be doc'ed so
>> future contributors are aware of it
>
> Good catch!!!
> It definitely would have unintentional side effect of incorrect orientation
> in subsequent tests.
> I updated the test to restore the orientation at the end of the test. Also
> documented the same.
hmm ... don't think that it will effect subsequent tests, though might be
mis-understanding the api doc of
Parameterized:
> When running a parameterized test class, instances are created for the
> cross-product of the test methods and the test
> data elements.
So just suggested to change the doc of the method, something like
Changes the parameter nodeOrientation and sets the table's orientation to
the new value
Alternatively, leave the parameter alone, just toggle the table's orientation
and change the forward/backward methods
to choose the keys based on the table's current orientation. Or fully
parameterize on the keys - sry, can't resist :)
-------------
PR: https://git.openjdk.java.net/jfx/pull/114
