On Mon, 23 Mar 2020 05:32:29 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> A simple readability cleanup for the files that were changed in #113. >> >> Note that the boolean property has an `instanceof` check that doesn't exist >> in the other properties. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > > Revert changes of anonymous classes usage Looks good with one minor formatting comment (which applies to all files). modules/javafx.base/src/main/java/javafx/beans/property/BooleanProperty.java line 183: > 182: } > 183: } Minor: can you add the trailing newline back in? We typically end each file with a single new-line; also this shows up as an unnecessary diff. ------------- PR: https://git.openjdk.java.net/jfx/pull/141
