On Tue, 24 Mar 2020 11:45:28 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The incremental >> webrev excludes the unrelated changes brought in by the merge/rebase. The >> pull request contains five additional commits >> since the last revision: >> - Merge branch 'master' into jdk_8241476 >> - Another approach for removing c++ warnings >> - Merge pull request #8 from openjdk/master >> >> Merge upstream >> - Remove build warning >> - Merge pull request #7 from openjdk/master >> >> merge from jfx > > The problem is that gcc, for whatever reason, started issuing a (useless) > warning if you pass the > `-Werror=implicit-function-declaration` option to gcc for C++ files. I don't > like the solution of removing that flag > for C files. I think the better solution will be to have a set of options > that are common to both C and C++ (all but > this one currently), and then add `-Werror=implicit-function-declaration` > only to the options for C. Until then, I > think we live with this warning. It's better than losing the checking for C > files. Like this? I think all C builds are covered. Gstreamer seems to have a Makefile with the flags. Not sure about libxml and libxlst inside javafx.web. ------------- PR: https://git.openjdk.java.net/jfx/pull/150
