On Fri, 3 Apr 2020 11:32:12 GMT, Michael Paus <mp...@openjdk.org> wrote:
>> @arapte Can you be one of the reviewers? >> >> @mipastgt I ran it against your test application, but if you have other >> tests you could run, that would be helpful. > > I've built a fresh JFX, with your changes applied to master, this morning. I > can confirm that the primary bug seems to > be fixed with these changes but I have observed some behaviour where I am not > sure whether it is correct or whether my > expectation is just wrong. 1. The total delta values are now accumulated > correctly for the regualar scroll events but > not for the following generated inertia events. They are still equal to the > delta values. Is that according to the > specification? From a practical point of view a programmer who relies on the > total delta values is probably much > surprised if the total delta is reset by the inertia events. 2. Is the > touch-count field only valid for touch-events > or why is it always zero? 3. The mouse-wheel behaviour is still wrong > because the total-deltas for mouse-wheel > generated scroll-events is still not 0 but this has probably another root > cause. These are all separate issues that could be explored with follow-on bugs. I'm not sure what the right behavior is for these or whether there is enough information from the OS to do anything about them (e.g., I suspect there is no way to get the touch count for these trackpad-generated gestures on macOS, nor do I really think it would be useful). You might file a follow-on issue for 1 and 3. Would you be able to review this? If not I'll ask @johanvos or @pankaj-bansal to be the second reviewer. ------------- PR: https://git.openjdk.java.net/jfx/pull/156
