Hi Jesper,

Welcome to OpenJFX.

Yes, it's a fine idea to say hello, so that 's taken care of. I presume you have read the CONTRIBUTING guidelines (since you sent the OCA you probably have)? [1]

Since your OCA has been sent, you can file a PR any time. It won't be marked as ready for review until your OCA is processed, though. When you do file it, choose "/signed" as the option to respond to the automated message.

-- Kevin

[1] https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md


On 4/6/2020 10:42 AM, Jesper Skov wrote:
Hi,

I happened to fall over this issue:

https://bugs.openjdk.java.net/browse/JDK-8198402

while reading another jfx PR.


I have a shot at a fix:

https://github.com/openjdk/jfx/compare/master...jskov:toggleGroupSync-JDK-8198402

But I was not entirely sure if just submitting a PR without saying hello
first was OK? :)


The OCA has been sent. Should I await some feedback from oracle-ca_us
before I submit the PR?

Cheers,
Jesper

Reply via email to