On Thu, 2 Apr 2020 12:58:11 GMT, Ambarish Rapte <[email protected]> wrote:
>> ButtonSkin adds a `ChangeListener` to `Control.sceneProperty()` which >> results in leaking the `ButtonSkin` itself when >> the `Button`'s skin is changed to a new `ButtonSkin`. Using a >> `WeakChangeListener` instead of `ChangeListener` solves >> the issue. >> Please take a look. > > Ambarish Rapte has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed review comment: cleanup the accelerator Marked as reviewed by kcr (Lead). ------------- PR: https://git.openjdk.java.net/jfx/pull/147
