On Sun, 19 Apr 2020 09:56:27 GMT, Jesper Skov <github.com+2720909+js...@openjdk.org> wrote:
>> The fix looks correct to me. Have you run all tests to ensure no regressions? >> >> I left a couple inline comments. > > @kevinrushforth I tested by: > ` > bash ./gradlew clean all test -x :web:test > ` > I assumed that would do it. > But I see use of ToggleButton in javafx.web, so that was clearly a faulty > assumption. > > I will try to get webkit working. I have failed getting web:tests to work. Both with java 11.0.7 and 14.0.0 (adoptajdk 14.0.1 not ready yet), I get the error below. And that is with both a locally built webkit, and the one from javafx-web-15-ea+3-linux.jar So it seems I am unable to run web:tests task on my box (Fedora 31, FWIW). Any suggestions for how to resolve this? ` > Task :web:test ***************************************************** WARNING: running web tests without building webkit. The webkit native library will be copied from the JDK, which might lead to failures in some web tests. To avoid these failures, you should either build webkit locally, copy the native webkit library from a recent build, or skip execution of web test cases with '-x :web:test' ***************************************************** Exception in thread "JavaFX Application Thread" # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007f4e01ae8a61, pid=78774, tid=78815 # # JRE version: OpenJDK Runtime Environment (11.0.7+10) (build 11.0.7+10) # Java VM: OpenJDK 64-Bit Server VM (11.0.7+10, mixed mode, tiered, compressed oops, g1 gc, linux-amd64) # Problematic frame: # V [libjvm.so+0x579a61] AccessInternal::PostRuntimeDispatch<G1BarrierSet::AccessBarrier<1097844ul, G1BarrierSet>, (AccessInternal::BarrierType)2, 1097844ul>::oop_access_barrier(void*)+0x1 # # Core dump will be written. Default location: Core dumps may be processed with "/usr/lib/systemd/systemd-coredump %P %u %g %s %t %c %h" (or dumping to /opt/sources/github/jfx/modules/javafx.web/core.78774) # # An error report file with more information is saved as: # /opt/sources/github/jfx/modules/javafx.web/hs_err_pid78774.log # # If you would like to submit a bug report, please visit: # https://github.com/AdoptOpenJDK/openjdk-support/issues # ` ------------- PR: https://git.openjdk.java.net/jfx/pull/167
