On Fri, 17 Apr 2020 15:14:19 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
> I just checked and there is nothing wrong with your merge. But somehow it > managed to confuse GitHub. Thanks, Kevin. A simple `git rebase master` and `git push --force` did the trick! I hope it's okay for me to add some advocacy to the conversation here. My initial comment makes it easy to miss the general context of this update. This pull request completes the project of adding support for e-paper displays that we started back in JavaFX 13. I would love to see these last few changes merged in time for JavaFX 15. Below are five reasons to merge this pull request into the next release: 1. It's small. It's only 50 lines of code — the last 3 percent of the entire project. 2. It's done. It completes the work already included in JavaFX 13, which was 1,812 lines of code and 97 percent of the project. 3. It's safe. The code runs only when the system properties include `glass.platform=Monocle` and `monocle.platform=EPD`, and even then, only when the system has an e-paper display with the EPD Controller frame buffer driver. There are no changes to any JavaFX code outside of the Monocle EPD platform. 4. It's tested. I tested the code in November with JDK 13 and JavaFX 14. I tested the code again this week with JDK 14 and JavaFX 15. I ran tests with Ubuntu OpenJDK 11 and 13 as well as AdoptOpenJDK 11 and 14. I tested older devices under Ubuntu 14.04 and newer devices under Ubuntu 20.04 Beta. All tests passed. 5. It's unique. This pull request makes JavaFX the only cross-platform application framework with built-in support for e-paper displays. It demonstrates that the Java slogan "write once, run anywhere" is as true today as it was in 1995, not just for different operating systems and processor architectures, but even for radically different display technologies like electronic ink. To my potential reviewers, @johanvos and @kevinrushforth, is there anything I can do to make your code review easier? ------------- PR: https://git.openjdk.java.net/jfx/pull/60
