On Wed, 22 Apr 2020 09:06:09 GMT, Jeanette Winzenburg <faste...@openjdk.org> wrote:
>> I checked and there is a case that (mostly) works today that will break with >> your proposed fix. I left a couple inline >> comments. >> I wonder if it is better to wait and fix it completely in >> [JDK-8242553](https://bugs.openjdk.java.net/browse/JDK-8242553). > >> >> I wonder if it is better to wait and fix it completely in >> [JDK-8242553](https://bugs.openjdk.java.net/browse/JDK-8242553). > > good idea - do it correctly once and for all :) Thanks @kevinrushforth for taking a detailed look at this. I wanted to fix this and then fix the buggy behavior change in JDK-8242553 separately. As my proposed Spinner.wrapValue() does not work well in some cases and it's going to get modified anyway - I guess, you and @kleopatra are right in suggesting to fix it entirely in JDK-8242553. I will close this PR. ------------- PR: https://git.openjdk.java.net/jfx/pull/174
