On Thu, 30 Apr 2020 07:08:24 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
> The system test file `TabPanePermuteGetTabsTest` was added to address exact > similar kind of issue > [JDK-8222457](https://bugs.openjdk.java.net/browse/JDK-8222457). The current > issue > [JDK-8237602](https://bugs.openjdk.java.net/browse/JDK-8237602) is just > another case of same type. So it seems good to > add a new test with similar existing tests. I myself had fixed the previous > issue, Can't remember why did I not > consider of a unit test then 🤔. yeah, if we don't document everything :))) Would you consider moving both into a unit test? Have one locally, could send it to you .. Also a minor quirk as to the naming: it should not name it "permutation" because it isn't from the perspective of the list change: the notification is a "replace". Btw, the pattern in the listener (of collecting up additions/removals) is a bit smelly - will fail as soon as you get disjoint additions (on the bright side: they don't happen in the current implementation of ObservableList but are allowed to), just something to keep in mind :) ------------- PR: https://git.openjdk.java.net/jfx/pull/201
