On Tue, 5 May 2020 10:50:40 GMT, Jeanette Winzenburg <faste...@openjdk.org> 
wrote:

> The issue is that ChoiceBox didn't sync its value to the replaced 
> SelectionModel's selectedItem if the item is null.
> 
> Fixed by removing the constraint from selectionModel property.
> 
> Added tests that failed before and passed after the fix. Note that I also 
> changed a test method in ChoiceBoxTest with
> an incorrect test assumption (which passed for the incorrect implementation).

@aghaisas I presume you will review this (as with the earlier fix it probably 
doesn't need two reviewers)?

-------------

PR: https://git.openjdk.java.net/jfx/pull/207

Reply via email to