On Mon, 11 May 2020 12:50:48 GMT, Jose Pereda <jper...@openjdk.org> wrote:
> With this PR, we pass directly the 16-bit unsigned short for a character > (unicode value) to the Java layer, avoiding > the cast with the C++ 8-bit char, that fails for non-ascii characters like > euro (€) or quote ("). > We also avoid the mapping between iOS keys and JavaFX `KeyCode`, except for > `ENTER` and `BACK_SPACE`, as the mapping > for some keys was wrong, like for "%", with ascii value 0x25, that was mapped > to KeyCode.LEFT. > Finally, the iOS keyboard is set to `UIKeyboardTypeASCIICapable`, to prevent > the display of the emoji keyboard, that > can't be currently processed. This indeed fixes JDK-8244735. It only touches ios-specific files, hence there is no impact on other platforms. ------------- Marked as reviewed by jvos (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/217