On Thu, 14 May 2020 19:22:54 GMT, Abhinay Agarwal <github.com+3197675+abhinayagar...@openjdk.org> wrote:
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus but the keyboard > is not visible. Ideally, the keyboard > should be shown again when the user taps on the TextInputControl. > This PR adds an event handler for `MouseEvent.MOUSE_CLICKED` event and shows > the keyboard if the TextInput control is > both editable and focused. out off my home-zone here, just fyi and in case it might be relevant to android skins as well: there's an umbrella issue to cleanup skin implementations [JDK-8241364](https://bugs.openjdk.java.net/browse/JDK-8241364) - both the android text skins look like leaking in the manually registered focus listener (not introduced here) and the eventHandler added here. Probably should be removed manually in dispose (or in the case of the focusListener, registered via skin api). ------------- PR: https://git.openjdk.java.net/jfx/pull/219
