On Thu, 14 May 2020 08:15:19 GMT, Bhawesh Choudhary <github.com+4208131+bhawes...@openjdk.org> wrote:
> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering > of rounded corner rectangle if four > corners have different radii. but same can be achieved via Path. to fix the > issue, in GraphicsContextJava.cpp while > rendering fillRoundedRect, check if all four corners have same radii. if yes, > use FILL_ROUNDED_RECT to draw it > otherwise construct a path from given rounded rect and draw it. The fix looks correct, but I want to test it. I left one minor comment on the test. modules/javafx.web/src/test/java/test/javafx/scene/web/CSSTest.java line 34: > 33: > 34: import java.awt.*; > 35: import java.awt.image.BufferedImage; As a best practice, we avoid Wildcard imports for packages (static imports of fields and methods within a class are sometimes fine for certain classes). ------------- PR: https://git.openjdk.java.net/jfx/pull/218
