On Thu, 21 May 2020 16:47:30 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> As discussed >> [here](https://github.com/openjdk/jfx/pull/201#issuecomment-621772586) >> during #201 , This PR converts the >> system tests in TabPanePermuteGetTabsTest.java to unit test. >> Thanks @kleopatra , for providing the test. I have added few more tests and >> found few failures. >> [JDK-8245528](https://bugs.openjdk.java.net/browse/JDK-8245528) is created >> to fix these failures, the failing tests are >> currently ignored using this bug. >> Please take a look. > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java > line 2293: > >> 2292: >> 2293: void test_disableAnimations() { >> 2294: closeTabAnimation.set(TabAnimation.NONE); > > Might be better to change this to `test_setAnimations(TabAnimation mode)` so > the test can restore it in the cleanup > method. Never mind. I see that the test constructs a new TabPane instance for each test, so there is no need to restore it. > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TabPaneSkinHeaderOrderTest.java > line 274: > >> 273: public void cleanup() { >> 274: stage.hide(); >> 275: } > > I recommend to restore animation here. Never mind. This is not needed since the test constructs a new TabPane instance for each test in the `@Before` method. ------------- PR: https://git.openjdk.java.net/jfx/pull/230
