On Tue, 19 May 2020 10:25:24 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:

> Issue : https://bugs.openjdk.java.net/browse/JDK-8245181
> 
> Root cause : The exception just gets logged and does not result in test 
> failure.
> 
> Fix : Added the mechanism to catch and handle UncaughtException. Test 
> test_rt35039_resetRootChildren fails with this
> mechanism. Fixed the test failure by adding the check in TreeTableView class. 
> In addition, unrelated to above fix, I
> have removed System.out.printlns that were causing log pollution.

modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java 
line 2563:

> 2562:                                 pMap.put(i, 
> e.getChange().getPermutation(i));
> 2563:                             }
> 2564:                         }

Hi Ajit, I am working on fix for 
[JDK-8193800](https://bugs.openjdk.java.net/browse/JDK-8193800),  This code of
handling permutation of table rows is not correct, and as part of the changes 
for this fix, this code would be changed
such that `pMap` will be removed. Could you please hold this change until
[JDK-8193800](https://bugs.openjdk.java.net/browse/JDK-8193800) is fixed.?

-------------

PR: https://git.openjdk.java.net/jfx/pull/224

Reply via email to