On Mon, 1 Jun 2020 09:54:23 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> - Updated libffi to 3.3. > > modules/javafx.media/src/main/native/gstreamer/3rd_party/libffi/include/ffitarget.h > line 53: > >> 52: #define FFI_TARGET_SPECIFIC_STACK_SPACE_ALLOCATION >> 53: #ifndef _MSC_VER >> 54: #define FFI_TARGET_HAS_COMPLEX_TYPE > > In the original release of [libffi > 3.2.1](https://github.com/libffi/libffi/releases/tag/v3.2.1), this line is > not > commented. which means it was commented in JavaFX. I cannot trace when and > why was it commented. Should it be reasoned > to whether enable it or not ? That's a good question. The commented line was there from the first commit (in 9, changeset 9231:241f9696e3ad, https://bugs.openjdk.java.net/browse/JDK-8043352) but I don't see a reason on why it was disabled. libffi is also built in the GraalVM project, and that line is not commented there. @sashamatveev or @kevinrushforth do you remember the reason? ------------- PR: https://git.openjdk.java.net/jfx/pull/242
