On Tue, 2 Jun 2020 21:01:05 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change isSortingInProgress to package scope
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java
> line 1807:
>
>> 1806:
>> 1807: boolean sortingInProgress;
>> 1808: boolean isSortingInProgress() {
>
> Minor: the field itself can be private.
Corrected in the next commit.
> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTablePosition.java
> line 82:
>
>> 81: // This causes issue by triggering a new TreeModificationEvent while
>> one TreeModificationEvent
>> 82: // is being handled currently.
>> 83: // This is kind of a copy constructor with different value for row.
>
> The first three lines of added comments don't really belong here. I would
> just document the new constructor as a
> copy-like constructor (with a different row) and mention that it is used by
> the TreeTableView::sort method.
Updated the doc in next commit, please take a look
-------------
PR: https://git.openjdk.java.net/jfx/pull/244
