On Tue, 19 May 2020 14:38:01 GMT, Kevin Rushforth <[email protected]> wrote:
>> @kevinrushforth brought to my notice that there is a PR >> (https://github.com/openjdk/jfx/pull/210) opened for the same >> issue by [schelldorfer](https://github.com/schelldorfer). I was not aware of >> this PR as it did not have 'rfr' label - >> which I look for. I picked up this issue from JBS and submitted the solution >> mentioned in JBS. >> I would *NOT* like to step on a new contributor's contribution. >> >> Now, I see that the original PR has been closed. Once his signed OCA has >> been recorded, we have two options : >> 1. I will integrate with this PR with due attribution given to >> [schelldorfer](https://github.com/schelldorfer) >> OR >> 2. I will withdraw my PR without integrating and >> [schelldorfer](https://github.com/schelldorfer) can reopen and submit >> his PR. > > @aghaisas that sounds fine to me. In order to attribute the fix, you will > need to wait for the OCA to be recorded. > > @schelldorfer once your OCA is recorded, which would you prefer to do? Create > a new PR yourself or have @aghaisas list > you as the contributor. I signed the OCA a few days ago and my name is listed on the page https://www.oracle.com/technetwork/community/oca-486395.html#s ------------- PR: https://git.openjdk.java.net/jfx/pull/220
