On Thu, 11 Jun 2020 23:28:41 GMT, Phil Race <p...@openjdk.org> wrote:

>> I should add that this is without any attempt to filter out `0` chars. Both 
>> `UnicodeTextTest` and  `UnicodeTextTest2`
>> run correctly with no crashes and no assertions when I comment out the 
>> (ineffective) loop checking for 0 and set `start
>> = str` leaving everything else as you have it in the current PR. Loading 
>> https://gluonhq.com/ in WebView works, too.
>
> I agree. the text array is now the subset for the run, so effectively 
> run.getStart() should be zero,
> so there should be no need for that call. This probably looks OK when there 
> is one run not otherwise.

You're both correct. I simplified it.

-------------

PR: https://git.openjdk.java.net/jfx/pull/249

Reply via email to