On Thu, 11 Jun 2020 13:26:33 GMT, Johan Vos <j...@openjdk.org> wrote:

>> Interestingly enough, I don't see a crash due to the 0 character, but I am 
>> seeing some new assertion warnings expecting
>> `length >= 0` even in cases where there isn't a 0 character.
>
> I saw that assertion as well, but that can come from cases where empty 
> TextRun instances are used (start == end). In
> that case, the length is 0, which pango considers silly, but it won't crash 
> on that (the content array is never
> examined in that case)

the crash with 0 is gone with the second patch indeed (1 str per Run), which 
might be a consequence of doing strlen
calculations before we send content down to the pango lib

-------------

PR: https://git.openjdk.java.net/jfx/pull/249

Reply via email to