On Fri, 1 May 2020 16:01:28 GMT, Jesper Skov
<[email protected]> wrote:
>> build.gradle line 3391:
>>
>>> 3390: doFirst {
>>> 3391: if (IS_STUB_RUNTIME_OPENJFX) {
>>> 3392: println
>>> "********************************************************"
>>
>> Perhaps this should be inside the `if (!IS_COMPILE_WEBKIT)` ?
>
> I assume you mean like this:
> `
> if (!IS_COMPILE_WEBKIT) {
> if (IS_STUB_RUNTIME_OPENJFX) {
> println ...
> } else {
> println ...
> }
> }
> `
> I do not like the additional indentation level, so I have left it as is.
>
> The semantics should be the same, as long as no one use stubs *and* compile
> webkit.
> Which should maybe rather cause a build exception?
>
> But it is not something I feel strongly for, so I am happy to change it :)
Yes, that's what I was suggesting, but I'm happy with the way it is.
-------------
PR: https://git.openjdk.java.net/jfx/pull/202
