On Wed, 10 Jun 2020 23:33:46 GMT, Kevin Rushforth <[email protected]> wrote:
>> ListCellSkin installs listeners to the ListView/fixedCellSize that introduce >> a memory leak, NPE on replacing the >> listView and incorrect update of internal state (see bug report for details) >> Fixed by removing the listeners (and the internal state had been copied from >> listView on change) and access of listView >> state when needed. >> Added tests that failed before and pass after the fix, plus a sanity test to >> guarantee same (correct) behavior >> before/after. > > @arapte can you review? Hmm .. bottleneck seems to be layout as such (including css), accessing an instance field vs. querying a property doesn't make a difference (at least none I could see). ------------- PR: https://git.openjdk.java.net/jfx/pull/251
