On Thu, 25 Jun 2020 23:59:47 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Rony G. Flatscher has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Incorporating Kevin's review comments (final int, fix for loop test, >> correct formatting). > > The API changes look good. Also, the CSR has been approved. > > The code changes in FXMLLoader look good. > > The newly added tests pass with your fix. > > I also verified that at least some of the newly added tests fail without fix > (good) > > Most of the rest of the comments are on formatting and code style, so this > looks about ready to go in. Kevin, thank you for your feedback and sponsorship! Hope that I have applied the changes to all affected files appropriately. (It is interesting for me that despite trying to adhere to the OpenJDK formatting, sometimes my own - decadelong trained :) - formattings slip thru without noticing it.) ------------- PR: https://git.openjdk.java.net/jfx/pull/192
