On Fri, 28 Aug 2020 14:55:55 GMT, Bhawesh Choudhary <bchoudh...@openjdk.org> wrote:
> Deprecate the public constructor of javafx.css.Selector as it should not be > public due to only being extended by > classes in same package. Deprecate the public constructor of > javafx.css.converter.ShapeConverter as its a singleton > class. Looks good. Added a single comment. modules/javafx.graphics/src/main/java/javafx/css/Selector.java line 47: > 46: * @deprecated This constructor was exposed erroneously and will be > removed in the next version. > 47: */ > 48: @Deprecated(since="16", forRemoval=true) Please direct the reader to the way of obtaining an instance of this class like you did for `ShapeConverter`. ------------- PR: https://git.openjdk.java.net/jfx/pull/290
