On Wed, 9 Sep 2020 11:59:35 GMT, Jeanette Winzenburg <faste...@openjdk.org>
wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> rename tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java
> line 1347:
>
>> 1345: final ComboBox<String> cb = new
>> ComboBox<>(FXCollections.observableArrayList("a", "b", "c"));
>> 1346: cb.setEditable(true);
>> 1347: StageLoader sl = new StageLoader(cb);
>
> shouldn't there be an analogous functional test for not-editable combo? There
> are both functional and low-level for
> editable, but only low-level for not editable.
I did not understand what low-level test mean here. But have added test for
navigation keys which verify using
`SelectionModel.getSelectedIndex()`. Please point if it is sufficient.
-------------
PR: https://git.openjdk.java.net/jfx/pull/172
