On Thu, 10 Sep 2020 17:20:07 GMT, Kevin Rushforth <[email protected]> wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added code comment as requested in review > > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinCleanupTest.java > line 68: > >> 66: installDefaultSkin(cell); >> 67: cell.updateListView(null); >> 68: listView.setFixedCellSize(100); > > I presume this test is just checking that no exception is thrown? If so, can > you add a comment to that effect? yeah, exactly :) Was NPE before fix (due to skin listening to property of previous listView and trying to access the current which is null). Added comment as requested ------------- PR: https://git.openjdk.java.net/jfx/pull/251
