On Fri, 11 Sep 2020 00:10:29 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added unit test for strokes
>
> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java
> line 447:
>
>> 445: public void setClip(int cx, int cy, int cw, int ch, WCImage
>> maskImage) {
>> 446: setClip(new Rectangle(cx, cy, cw, ch));
>> 447: state.setClipMaskImage(maskImage);
>
> Should all of the other variants of setClip (the ones that don't take a
> maskImage) set the clipMaskImage to null?
> Otherwise it seems that it might not be reset to null in all cases.
added setting of null to maskImage for all the overloads of setClip where mask
image is not present.
> modules/javafx.web/src/main/java/com/sun/javafx/webkit/prism/WCGraphicsPrismContext.java
> line 520:
>
>> 518: state.apply(g1);
>> 519: g1.setPaint(paint);
>> 520: if(stroke != null) {
>
> Minor: there should be a space after the `if`.
Fixed
-------------
PR: https://git.openjdk.java.net/jfx/pull/213
