On Thu, 8 Oct 2020 22:21:06 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change range after clamping
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DLight.cc line 64:
>
>> 62: }
>> 63:
>> 64: /*void D3DLight::setRange(float r) {
>
> Remove this unused function?
I forgot to mention this point. These setter functions for color and position
(and range) are never used since whenever
there is a change in the java side the whole array and lights are recreated
instead of being adjusted for the change.
I'm not familiar enough with the memory model of JNI, but it seems expensive to
re-render everything on every change (I
think that the mesh is also recreated every time in the native code). Is this
the way it's supposed to work?
-------------
PR: https://git.openjdk.java.net/jfx/pull/43
