On Thu, 8 Oct 2020 07:57:17 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8244297 >> Fixing some wrong imports > > I have reviewed only in perspective of Java coding guidelines. I still have > to review the functionality. > Most of the comments are minor like variable name change and typos. I would > recommend you to please go through all of > the code to find and fix any other corrections related to Coding guidelines. Thank you for the feedback. I will integrate some of them into JMemoryBuddy! (and update the PR to reflect these changes) To check whether the Library is working properly, you can check the existing unit-tests and Travis builds in the original repository: https://github.com/Sandec/JMemoryBuddy I've copied the code of the original project because adding it as a dependency is not allowed. I don't want to make changes in the copy, except for changes in the default configuration. But I don't want to maintain two versions of the Library, so I don't plan to confirm all coding guidelines of the JFX-project inside of JMemoryBuddy. I think that's the way how other Libraries are also handled, like the C-Code which is used for the WebView. Otherwise, it would be bad for maintenance. I hope that's ok, otherwise, I will have to cancel the PR. ------------- PR: https://git.openjdk.java.net/jfx/pull/204
