On Sat, 17 Oct 2020 13:43:41 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8244297 >> Fixed unit-test > > modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 42: > >> 40: >> 41: /** >> 42: * Checkout <a >> href="https://github.com/Sandec/JMemoryBuddy";>https://github.com/Sandec/JMemoryBuddy</a> >> for more documentation. > > Can you add 1 or 2 sentences before this pointer describing (at a high level) > the purpose of this class? done > modules/javafx.base/src/test/java/test/util/memory/JMemoryBuddy.java line 235: > >> 233: } >> 234: >> 235: public static interface MemoryTestAPI { > > Can you add a (short) class javadoc comment? One thing to document is how and > whether users of the API should implement it. done ------------- PR: https://git.openjdk.java.net/jfx/pull/204
