On Tue, 27 Oct 2020 10:44:00 GMT, Johan Vos <[email protected]> wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update JBS reference in RegionTest
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line
> 303:
>
>> 301: }
>> 302:
>> 303: private static double scaledCeil(double value, double scale) {
>
> Can you explicitly add here that this method guarantees
> `scaledCeil(scaledCeil(val, scale), scale) == scaledCeil (val, scale)`
>
> It seems other code already assumed this, but it should not be taken for
> granted, so now that your fix assures this is the case, it can be taken for
> granted.
Ok, makes sense, I will add that.
-------------
PR: https://git.openjdk.java.net/jfx/pull/336
