On Fri, 20 Nov 2020 11:30:18 GMT, Jose Pereda <jper...@openjdk.org> wrote:

>> As commented in the [JBS 
>> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), the default UI 
>> scale 1.0 is used to perform initial calculations of preferred sizes of the 
>> scene, even if the scale has already a different value (i.e 175%). As a 
>> workaround, calling `Stage::sizeToScene` fix it, as it forces to do new 
>> calculations but now with the correct UI scale.
>> 
>> This PR moves the call to `Window::updateOutputScales` before the scene 
>> initialization takes place, so the UI scale is correctly set for the initial 
>> preferred size of the scene, and no workaround is required.
>> 
>> It also provides a system test that can be tested on Linux and Windows. 
>> Before applying the fix, the `Check` text of the checkboxes is rendered as 
>> `Che...`. With the fix, the test verifies, for a given UI scale, that the 
>> rendered text is `Check`.
>
> Jose Pereda has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Use assertTrue instead of try-catch

Looks good to me, verified test and sample app on multi screen.

-------------

Marked as reviewed by arapte (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/351

Reply via email to