On Thu, 3 Dec 2020 13:34:04 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> I tested the patch, and it works for me (MacOS Catalina, 10.15.7) >> I will look into more detail in the code, as I'm slightly worried about not >> following the Apple conventions. From experience, this often leads to more >> issues sooner or later. > > Thanks for checking. I'll remove the debug print statements, turn off verbose > logging, and send it out for review. I would appreciate a thorough review of > the code. Given the way JavaFX initializes the macOS application and sets the > system menu bar, this seems like the least intrusive and least risky fix, but > it would be nice if we can find a better fix that isn't overly complicated or > risky. For some reason, the GitHub actions test results weren't added by the Skara bot. I filed [SKARA-839](https://bugs.openjdk.java.net/browse/SKARA-839) to track this. You can [click here](https://github.com/kevinrushforth/jfx/actions/runs/398484208) to see the results of the GitHub action for the most recent commit I pushed. ------------- PR: https://git.openjdk.java.net/jfx/pull/361
