On Tue, 8 Dec 2020 21:34:46 GMT, Jose Pereda <[email protected]> wrote:

>> This PR fixes a regression introduced in 
>> [JDK-8199592](https://bugs.openjdk.java.net/browse/JDK-8199592), where scene 
>> initialization was moved after updating output scales. However, in case of 
>> embedded windows (used by `JFXPanel` or `FXCanvas`), the scene has to be 
>> initialized before.
>> 
>> A test has been included. Before applying the fix, the JFXPanel is rendered 
>> with a garbled image, and after the fix, the rendering is correct.
>
> Jose Pereda has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Add new line at the end of the test file

tests/system/src/test/java/test/robot/javafx/embed/swing/JFXPanelHiDPITest.java 
line 68:

> 66:     private static MyApp myApp;
> 67: 
> 68:     private static final double SCALE = 1.25; // 1.25, 1.5, 1.75

Can you add some explanation on these values? Why are the other commented 
values there?

-------------

PR: https://git.openjdk.java.net/jfx/pull/364

Reply via email to