On Tue, 27 Oct 2020 23:50:08 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> My preference would be for `SpotLight` to subclass `PointLight`. I also 
>> somewhat prefer the 1/2 angle (radius) rather than diameter to specify the 
>> spread angles (inner and outer).
>
> Not that it's all that relevant, but I will note that the (very old) Java 3D 
> API also had 
> [SpotLight](https://download.java.net/media/java3d/javadoc/1.5.0/javax/media/j3d/SpotLight.html)
>  as a subclass of 
> [PointLight](https://download.java.net/media/java3d/javadoc/1.5.0/javax/media/j3d/PointLight.html).

Is the old implementation worth looking at, or is is completely different?

I updated the API after subclassing `PointLight`. After we settle on it I will 
submit a CSR and we can move on to the implementation.

-------------

PR: https://git.openjdk.java.net/jfx/pull/334

Reply via email to