On Wed, 6 Jan 2021 11:16:07 GMT, Ambarish Rapte <[email protected]> wrote:
>> `TabPaneSkin` installs some listeners that are not removed when >> `TabPaneSkin` is changed. >> The fix converts listeners to WeakListeners and also removes them on dispose. >> >> There is a NPE check change needed in `isHosrizontal()`. Without this check >> it causes NPE if pulse is in progress while TabPaneSkin is getting disposed. >> >> `SkinMemoryLeakTest` already had a test which only needed to be enabled. >> Test fails before and passes after this change. > > Ambarish Rapte has updated the pull request incrementally with two additional > commits since the last revision: > > - Space corrections in tests > - Review update: cleanup and corrections Looks good. ------------- Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/318
